Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix issue that IP type cannot pass JDBC formatter #275

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

chloe-zh
Copy link
Member

@chloe-zh chloe-zh commented Nov 7, 2019

Issue #, if available:

Description of changes:

  • Fixed the JDBC formatter for the IP type.
  • Appended dataset with field of IP type.
  • Added and passed the integration test, manually sanity tested on Kibana.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@galkk galkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for fast turnaround

Copy link
Contributor

@abbashus abbashus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chloe-zh chloe-zh merged commit a332808 into opendistro-for-elasticsearch:master Nov 8, 2019
@chloe-zh chloe-zh deleted the IP-type branch March 3, 2020 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants