This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support NOT EXISTS for nested query #200
Merged
penghuo
merged 5 commits into
opendistro-for-elasticsearch:master
from
penghuo:nested-exists
Oct 4, 2019
Merged
Support NOT EXISTS for nested query #200
penghuo
merged 5 commits into
opendistro-for-elasticsearch:master
from
penghuo:nested-exists
Oct 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenmk
reviewed
Sep 30, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/domain/Condition.java
Outdated
Show resolved
Hide resolved
arsenmk
reviewed
Sep 30, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/rewriter/nestedfield/Where.java
Show resolved
Hide resolved
dai-chen
reviewed
Oct 2, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/query/maker/Maker.java
Show resolved
Hide resolved
src/test/java/com/amazon/opendistroforelasticsearch/sql/esintgtest/SubqueryIT.java
Outdated
Show resolved
Hide resolved
galkk
reviewed
Oct 2, 2019
src/test/java/com/amazon/opendistroforelasticsearch/sql/esintgtest/SubqueryIT.java
Outdated
Show resolved
Hide resolved
galkk
reviewed
Oct 2, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/query/maker/Maker.java
Outdated
Show resolved
Hide resolved
galkk
reviewed
Oct 2, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/rewriter/nestedfield/Where.java
Outdated
Show resolved
Hide resolved
dai-chen
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
abbashus
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #199
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.