This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Case functions support: LOWER, UPPER #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 5, 2019 13:18
penghuo
reviewed
Sep 5, 2019
| "WHERE LOWER(e.lastname)='duke' " + | ||
| "GROUP BY UPPER(e.firstname) "; | ||
|
|
||
| System.out.println(executeQuery(query)); |
There was a problem hiding this comment.
Done, I feel that we need codestyle rule for those slips :)
penghuo
reviewed
Sep 5, 2019
| * Generates next id for given method name. The id's are increasing for each method name, so | ||
| * nextId("a"), nextId("a"), nextId("b") will return a_1, a_2, b_1 | ||
| */ | ||
| public String nextId(String methodName) { |
There was a problem hiding this comment.
I think currently, the methodName is cached in request level. If i am right, does this cached method could be shared by different request?
There was a problem hiding this comment.
No. The SqlFunctions is per-request, and this is instance field
dai-chen
reviewed
Sep 5, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/utils/SQLFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/sql/utils/SQLFunctions.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #128
Description of changes:
Added 2 new functions LOWER and UPPER that receive field name as a first parameter and, potentially, locale
Changed identifier generation strategy to id per function name instead of global id
While I feel that SQLFunctions should be refactored, to expedite the process as of now I'm adding just functions implemented by analogy with trim() and substring() functions
Testing
integration testing, testing via kibana
Itegration tests include ORDER BY and GROUP BY clauses to ensure that everything is working.
Found 2 new issues that will be addressed separately: #176 , #175
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.