Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Removed timeouts from flaky tests, replacing them with mocked clock to check invariants #172

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

galkk
Copy link
Contributor

@galkk galkk commented Aug 29, 2019

Issue #170

Description of changes:
Removed timeouts from flaky tests, replacing them with mocked clock to check invariants

Testing

./gradlew build

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@galkk galkk requested review from penghuo, jngz-es and dai-chen August 29, 2019 18:36
Copy link
Contributor

@abbashus abbashus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! Our IT is taking more and more time and it's really not productive to rerun it once or even more.

@galkk galkk merged commit d13ad57 into opendistro-for-elasticsearch:master Aug 29, 2019
@galkk galkk deleted the fix-undeterminism-in-unit-test branch August 29, 2019 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants