This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # elasticsearch/src/main/java/com/amazon/opendistroforelasticsearch/sql/elasticsearch/executor/protector/ElasticsearchExecutionProtector.java
Codecov Report
@@ Coverage Diff @@
## develop #1022 +/- ##
=============================================
+ Coverage 99.87% 99.89% +0.01%
+ Complexity 2409 2402 -7
=============================================
Files 234 234
Lines 5527 5464 -63
Branches 358 326 -32
=============================================
- Hits 5520 5458 -62
Misses 5 5
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
penghuo
reviewed
Jan 29, 2021
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/ast/tree/Head.java
Show resolved
Hide resolved
dai-chen
reviewed
Jan 29, 2021
dai-chen
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. Thanks for the refactoring!
penghuo
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
davidcui1225
added a commit
to davidcui1225/sql
that referenced
this pull request
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#930
Description of changes:
head
command syntax to simplyhead [N]
where the optional argument N is the number of results to returnBreaking Changes Note: We have made breaking changes in the syntax of
head
command from previoushead [keeplast = (true | false)] [while "("<boolean-expression>")"] [N]
to currenthead [N]
. We are no longer supporting thekeeplast
andwhile
options.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.