This repository has been archived by the owner on Mar 31, 2021. It is now read-only.
Add support for connection string abbreviations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common for ODBC connection strings [2] Added unit test to validate that these connection string changes work
jordanw-bq
reviewed
Mar 5, 2020
src/elasticodbc/dlg_specific.c
Outdated
| @@ -142,11 +142,15 @@ BOOL copyConnAttributes(ConnInfo *ci, const char *attribute, | |||
| STRCPY_FIXED(ci->drivername, value); | |||
| else if (stricmp(attribute, INI_SERVER) == 0) | |||
| STRCPY_FIXED(ci->server, value); | |||
| else if (stricmp(attribute, INI_HOST) == 0) | |||
There was a problem hiding this comment.
Do we want to combine this with the previous case, like in L149-50 and L152-3?
There was a problem hiding this comment.
Yes, will update this.
jordanw-bq
approved these changes
Mar 5, 2020
rupal-bq
approved these changes
Mar 5, 2020
This was referenced Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6
Added support for user and password abbreviations (UID/PWD)
Added support for host instead of server and updated defines to match names properly
Added unit test to validate that these connection string changes work
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.