Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add support to pass basic-auth in endpoint url #35

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

keety
Copy link
Contributor

@keety keety commented Jan 21, 2020

example :

perf-top --endpoint https://username:password@cluster_endpoint --dashboard ClusterOverview

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…csearch#34)

Fixes issue (opendistro-for-elasticsearch#34)  where user can pass basic auth credentials in the
endpoint

example :
```
perf-top --endpoint https://username:password@cluster_endpoint --dashboard ClusterOverview

```
@keety keety changed the title Add support to pass basic-auth in endpoint url (#34) Add support to pass basic-auth in endpoint url Jan 21, 2020
@keety keety changed the title Add support to pass basic-auth in endpoint url Add support to pass basic-auth in endpoint url #34 Jan 21, 2020
@keety keety changed the title Add support to pass basic-auth in endpoint url #34 Add support to pass basic-auth in endpoint url Jan 21, 2020
@keety keety requested review from ktkrg and ticheng-aws January 21, 2020 16:37
Copy link
Contributor

@ktkrg ktkrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants