This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support https requests without certificate authentication #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditac
reviewed
May 6, 2019
lib/perf-top/util/generate-data.js
Outdated
| @@ -73,8 +76,13 @@ function makeHttpRequest (httpOptions, done) { | |||
| done(rawData); | |||
| }); | |||
| }; | |||
|
|
|||
| var req = http.request(httpOptions, respond); | |||
| var protocol = http; | |||
There was a problem hiding this comment.
I think client might be a better name for this variable.
lib/perf-top/util/generate-data.js
Outdated
| protocol = https; | ||
| urlOptions.rejectUnauthorized = false; | ||
| } | ||
| var protocol = (urlOptions.protocol == "https:") ? https : http; |
There was a problem hiding this comment.
We seem to be doing this twice. We can remove the if block
There was a problem hiding this comment.
Oops. Removed the repetition.
ditac
approved these changes
May 6, 2019
yeajung
changed the title
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample command for endpoint with HTTPS protocol:
./perf-top-linux --dashboard NodeAnalysis --endpoint https://localhost:9600By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.