This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve Test Coverage to 81% #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=============================================
+ Coverage 62.12% 81.12% +19.00%
- Complexity 261 319 +58
=============================================
Files 39 39
Lines 1893 1770 -123
Branches 144 134 -10
=============================================
+ Hits 1176 1436 +260
+ Misses 637 232 -405
- Partials 80 102 +22
Continue to review full report at Codecov.
|
rguo-aws
reviewed
Jan 6, 2021
...mazon/opendistro/elasticsearch/performanceanalyzer/config/PerformanceAnalyzerController.java
Outdated
Show resolved
Hide resolved
...opendistro/elasticsearch/performanceanalyzer/listener/PerformanceAnalyzerSearchListener.java
Outdated
Show resolved
Hide resolved
adityaj1107
reviewed
Jan 7, 2021
.../opendistro/elasticsearch/performanceanalyzer/collectors/MasterServiceEventMetricsTests.java
Outdated
Show resolved
Hide resolved
…ormance-analyzer into coverage
adityaj1107
approved these changes
Jan 8, 2021
rguo-aws
approved these changes
Jan 8, 2021
yujias0706
added a commit
that referenced
this pull request
Jan 15, 2021
commit d141dc1 Author: Ruizhen Guo <[email protected]> Date: Tue Jan 12 10:36:50 2021 -0800 Add integ tests for OS metrics(cpu, page fault) (#252) * Add integ tests for OS metrics(cpu, page fault) commit 8c04a7e Author: Yu Sun <[email protected]> Date: Fri Jan 8 10:14:30 2021 -0800 Improve Test Coverage to 81% (#258) * pending tests to be tested on linuxOS only * add UT for MasterServiceEventMetricsTests * add UT for PerformanceAnalyzerSearchListenerTests * move linuxOS check to @BeforeClass * add UT for MasterServiceMetricsTests * add UT for NodeStatsSettingHandlerTests * add UT for WhoAmI package * remove unused PA reader tests * clean metricQueue before running every test * pending tests to be tested on linuxOS only * add UT for MasterServiceEventMetricsTests * add UT for PerformanceAnalyzerSearchListenerTests * move linuxOS check to @BeforeClass * add UT for MasterServiceMetricsTests * add UT for NodeStatsSettingHandlerTests * add UT for WhoAmI package * remove unused PA reader tests * clean metricQueue before running every test * add UT for PerformanceAnalyzerActionFilterTests * add UT for PerformanceAnalyzerActionListenerTests * add UT for PerformanceAnalyzerControllerTests * add UT for EventLogFileHandlerTests * exclude test for ClusterSettingsManager.java * code review changes Co-authored-by: Yu Sun <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #, if available:
Description of changes:
ClusterSettingsManager.javafor coverage, not able to write UT for more coverage due tojava.net.ConnectException: Connection refusedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.