This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve Test coverage up to 48% #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=============================================
+ Coverage 31.77% 48.00% +16.22%
- Complexity 116 195 +79
=============================================
Files 39 39
Lines 2008 2000 -8
Branches 150 150
=============================================
+ Hits 638 960 +322
+ Misses 1335 985 -350
- Partials 35 55 +20 Continue to review full report at Codecov.
|
yu-sun-77
force-pushed
the
test-coverage
branch
from
5237c28 to
3162c57
Compare
yu-sun-77
changed the title
rguo-aws
approved these changes
Dec 8, 2020
| assertEquals(CircuitBreaker.FIELDDATA, metrics.get(1).getType()); | ||
| assertEquals(CircuitBreaker.IN_FLIGHT_REQUESTS, metrics.get(2).getType()); | ||
| assertEquals(CircuitBreaker.ACCOUNTING, metrics.get(3).getType()); | ||
| assertEquals(CircuitBreaker.PARENT, metrics.get(4).getType()); |
There was a problem hiding this comment.
Can we do some basic sanity check to verify the circuit breaker values here ?
adityaj1107
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #, if available:
#253
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.