This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Merge from 1.11 to master - support latest ES version #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
===========================================
- Coverage 14.09% 9.96% -4.14%
+ Complexity 65 50 -15
===========================================
Files 39 39
Lines 2015 2018 +3
Branches 150 150
===========================================
- Hits 284 201 -83
- Misses 1722 1809 +87
+ Partials 9 8 -1
Continue to review full report at Codecov.
|
|
Updated the RCA version to the latest odfe version 1.11 - The build will fail until I get this PR merged on the RCA package. |
sidheart
approved these changes
Nov 13, 2020
| id 'com.github.spotbugs' version '4.0.0' | ||
| id 'jacoco' | ||
| } | ||
|
|
||
| spotbugsMain { | ||
| excludeFilter = file("checkstyle/findbugs-exclude.xml") | ||
| effort = 'max' | ||
| ignoreFailures = false | ||
| ignoreFailures = true |
There was a problem hiding this comment.
Do we have spotbugs failures which we need to ignore?
There was a problem hiding this comment.
As we are doing reverse merge, It includes all the old spotbug failures.
khushbr
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #, if available:
Description of changes:
Merge 1.11 branch to master.
Update the master to use the latest ES version and plugin version.
Changes that will be addressed in the next PR:
Need to update SpotBug - ignoreFailures to true.
Tests:
Spun a docker and tested
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.