-
Notifications
You must be signed in to change notification settings - Fork 49
set up jacoco for code coverage #234
set up jacoco for code coverage #234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage ? 14.09%
Complexity ? 65
=========================================
Files ? 39
Lines ? 2015
Branches ? 150
=========================================
Hits ? 284
Misses ? 1722
Partials ? 9 Continue to review full report at Codecov.
|
build.gradle
Outdated
violationRules { | ||
rule { | ||
limit { | ||
minimum = 0.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail if you set it to 80% as we don't have that coverage today, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you're referring to outdated version of code, I've changed to 0.0 for now. Can you please refresh and review again? Thanks.
build.gradle
Outdated
|
||
jacocoTestReport { | ||
reports { | ||
xml.enabled false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should enable at least one of the reports, is html enabled by default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest code has been changed to true
. Can you please refresh and review again? Thanks.
build.gradle
Outdated
} | ||
|
||
rule { | ||
enabled = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to keep verification to false for now ?
@yu-sun-77 can we create an issue and add it in the |
I've created an issue and update description. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #, if available: #236
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.