This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add Master Throttling Collector Metrics #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Code change is for Master Throttling of Pending task. It will publish two metric 1) Total throttled tasks at master node 2) Number of task on which data node is actively retrying. This feature is yet to be contributed to Opensource ES. I have added the check for availability of this feature in collector so building with or without this feature will pass. If this feature is not available then collector will simply return.
PR of this was mistakenly merged before approval. Raised same PR again.
Old PR: #217
Testing
/gradlew test Successful
Tested in test domain by replacing JAR.
Tmp file
^master_throttling_metrics {"current_time":1602617137529} {"Data_RetryingPendingTasksCount":0,"Master_ThrottledPendingTasksCount":0}$
Verified metric from table
sqlite> select * from Master_ThrottledPendingTasksCount; 0.0|0.0|0.0|0.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.