code review changes

opendistro-for-elasticsearch · Jan 7, 2021 · f20228d · f20228d
1 parent 2d56891
commit f20228d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/...on/opendistro/elasticsearch/performanceanalyzer/config/PerformanceAnalyzerController.java b/...on/opendistro/elasticsearch/performanceanalyzer/config/PerformanceAnalyzerController.java
@@ -1,23 +1,20 @@
 package com.amazon.opendistro.elasticsearch.performanceanalyzer.config;
 
-import com.google.common.annotations.VisibleForTesting;
+import com.amazon.opendistro.elasticsearch.performanceanalyzer.ESResources;
+import com.amazon.opendistro.elasticsearch.performanceanalyzer.PerformanceAnalyzerPlugin;
+import com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.ScheduledMetricCollectorsExecutor;
+import com.amazon.opendistro.elasticsearch.performanceanalyzer.config.overrides.ConfigOverridesWrapper;
+import com.amazon.opendistro.elasticsearch.performanceanalyzer.metrics.PerformanceAnalyzerMetrics;
 import java.io.File;
 import java.nio.file.Files;
 import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.List;
 import java.util.Scanner;
-
-import com.amazon.opendistro.elasticsearch.performanceanalyzer.config.overrides.ConfigOverridesWrapper;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-import com.amazon.opendistro.elasticsearch.performanceanalyzer.ESResources;
-import com.amazon.opendistro.elasticsearch.performanceanalyzer.metrics.PerformanceAnalyzerMetrics;
-import com.amazon.opendistro.elasticsearch.performanceanalyzer.PerformanceAnalyzerPlugin;
-import com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.ScheduledMetricCollectorsExecutor;
-
 public class PerformanceAnalyzerController {
     private static final String PERFORMANCE_ANALYZER_ENABLED_CONF = "performance_analyzer_enabled.conf";
     private static final String RCA_ENABLED_CONF = "rca_enabled.conf";
@@ -31,7 +28,7 @@ public class PerformanceAnalyzerController {
     private boolean rcaEnabled;
     private boolean loggingEnabled;
     private boolean batchMetricsEnabled;
-    @VisibleForTesting volatile int shardsPerCollection;
+    private volatile int shardsPerCollection;
     private static final boolean paEnabledDefaultValue = false;
     private static final boolean rcaEnabledDefaultValue = true;
     private static final boolean loggingEnabledDefaultValue = false;

diff --git a/...ndistro/elasticsearch/performanceanalyzer/listener/PerformanceAnalyzerSearchListener.java b/...ndistro/elasticsearch/performanceanalyzer/listener/PerformanceAnalyzerSearchListener.java
@@ -43,7 +43,7 @@ public PerformanceAnalyzerSearchListener(final PerformanceAnalyzerController con
 
     @Override
     public String toString() {
-        return PerformanceAnalyzerSearchListener.class.getName();
+        return PerformanceAnalyzerSearchListener.class.getSimpleName();
     }