This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding the Json Parser Object as the Class Member Variable #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidheart
previously approved these changes
Oct 30, 2020
.../com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryActionRequestHandler.java
Outdated
Show resolved
Hide resolved
sidheart
previously approved these changes
Oct 30, 2020
sruti1312
previously approved these changes
Oct 30, 2020
|
@aditjind There are 6 test failures. It might be good to rebase and re-trigger the CI ? |
adityaj1107
force-pushed
the
json-object
branch
from
7800616 to
f54c3c9
Compare
adityaj1107
commented
Nov 4, 2020
.../com/amazon/opendistro/elasticsearch/performanceanalyzer/rest/QueryActionRequestHandler.java
Outdated
Show resolved
Hide resolved
ricardolstephen
approved these changes
Nov 4, 2020
|
can we add in the description of the PR; the motivation for the change ? |
Done |
sidheart
approved these changes
Nov 13, 2020
sruti1312
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: Instead of creating a new JsonParser() variable every-time creating one which will load whenever the Action Handler loads.
Description of changes: Adding the Json Parser Object as the Class Member Variable
Tests:
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.