Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fixing Spotbugs issue #500

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Fixing Spotbugs issue #500

merged 5 commits into from
Oct 30, 2020

Conversation

adityaj1107
Copy link
Contributor

@adityaj1107 adityaj1107 commented Oct 30, 2020

Fixes #: Fixing Spotbugs issues which are blocking the build of the PA packages.

Description of changes: Spotbugs Error thrown is


Bug type URF_UNREAD_FIELD (click for details)In class 
com.amazon.opendistro.elasticsearch.performanceanalyzer.decisionmaker.actions.CacheClearAction$SummaryField 
com.amazon.opendistro.elasticsearch.performanceanalyzer.decisionmaker.actions.CacheClearAction$Summary.canUpdateAt 
CacheClearAction.java:[line 151]
--

But actually these variables are used to in Serializing to the Json.
This is a false alarm by spotBugs. Therefore added the suppress of errors.

Tests:

If new tests are added, how long do the new ones take to complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sruti1312
sruti1312 previously approved these changes Oct 30, 2020
khushbr
khushbr previously approved these changes Oct 30, 2020
@khushbr khushbr merged commit a668b03 into master Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants