Add ITs for JVM old gen policy #499
Conversation
| @@ -278,7 +278,7 @@ synchronized int insertRow(String tableName, List<Object> row) throws SQLExcepti | |||
| recordsWithMaxFieldValue = create.select().from(tableName).where(DSL.field(field) | |||
| .eq(create.select(max(field)).from(tableName))).fetch(); | |||
| } catch (DataAccessException dex) { | |||
| LOG.error("Error querying table {}", tableName, dex); | |||
| //LOG.warn("Error querying table {}", tableName, dex); | |||
| @@ -120,4 +118,39 @@ public CacheClearAction build() { | |||
| return new CacheClearAction(appContext, coolOffPeriodInMillis, canUpdate); | |||
| } | |||
| } | |||
|
|
|||
| public static class Summary { | |||
There was a problem hiding this comment.
Can we make this as an util class or rename as CacheClearActionSummary?
There was a problem hiding this comment.
Since this Summary is only used as a Json container within each action class(similar to the Builder class within the action class), I would like to leave it as it is. We can make them as separate classes if needed in the future
| @AErrorPatternIgnored( | ||
| pattern = "PersistableSlidingWindow:<init>()", | ||
| reason = "Persistence base path can be null for integration test.") |
There was a problem hiding this comment.
This is fixed with Sid's PR. We dont need to add them here
There was a problem hiding this comment.
thanks for catching this. Yes. let me remove those in my next PRs(I am creating a few more ITs to cover corner cases in JVM decider)
There was a problem hiding this comment.
done, removed this pattern
| @@ -72,7 +73,7 @@ protected double getMaxOldGenSizeOrDefault(final double defaultValue) { | |||
| } | |||
| double ret = | |||
| SQLParsingUtil | |||
| .readDataFromSqlResult(heapMaxMetric.getData(), MEM_TYPE.getField(), OLD_GEN.toString(), MetricsDB.MAX); | |||
| .readDataFromSqlResult(heapMaxMetric.getData(), MEM_TYPE.getField(), HEAP.toString(), MetricsDB.MAX); | |||
There was a problem hiding this comment.
I see that you have updated OLD_GEN to HEAP. The method says getMaxOldGenSizeOrDefault. Is there a reason why this change was made? Do we want to rename the method?
There was a problem hiding this comment.
yes, this was a bug I found in old gen RCA. Heap usage is supposed to be calculated by (old gen usage)/(max total heap size). but for some reason, we calculated it by (old gen usage)/(max old gen size)
There was a problem hiding this comment.
done. added a new function to retrieve HEAP and leave the OLD_GEN unchanged
There are some tests failing |
…Rest endpoint
Fixes #:
Description of changes:
Add ITs for JVM old gen policy. This PR fixes a few minor issues in IT framework to allow IT to retrieve persisted action list from rest endpoint. We also add six ITs to cover the happy scenario of old gen policy in JVM decider.
Those ITs are :
ITs that triggers LevelOne/LevelTwo/LevelThree action builder (dedicated master / multinode)
Tests:
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.