This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
PersistableSlidingWindow#load() modification #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PersistableSlidingWindow#load() will no longer throw an IOException when it is called with a Path that doesn't exist
sruti1312
reviewed
Oct 26, 2020
...lasticsearch/performanceanalyzer/rca/framework/api/aggregators/PersistableSlidingWindow.java
Outdated
Show resolved
Hide resolved
sruti1312
previously approved these changes
Oct 27, 2020
| // setting the last write time to now will cause our first write to occur 5 minutes after construction | ||
| this.lastWriteTimeEpochMs = Instant.now().toEpochMilli(); | ||
| try { | ||
| if (enablePersistence && Files.exists(filePath)) { |
There was a problem hiding this comment.
Can we add a log message when enablePersistence is not set or when file does not exist in the path? Even debug level log would be great.
There was a problem hiding this comment.
Added more logging in the most recent commit
sruti1312
approved these changes
Oct 27, 2020
yojs
approved these changes
Oct 28, 2020
adityaj1107
approved these changes
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: A series of ITs that failed on this error log line
Description of changes:
when it is called with a Path that doesn't exist
Tests:
If new tests are added, how long do the new ones take to complete N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.