Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Match dependencies with writer #393

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Match dependencies with writer #393

merged 2 commits into from
Aug 24, 2020

Conversation

sruti1312
Copy link
Contributor

Fixes #:
Dependency conflicts with the writer

Description of changes:
Modifies dependency version to match with the writer
Match plugin release version

Tests:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sruti1312 sruti1312 requested review from ktkrg and sidheart August 22, 2020 02:44
sidheart
sidheart previously approved these changes Aug 24, 2020
ktkrg
ktkrg previously approved these changes Aug 24, 2020
Copy link
Contributor

@ktkrg ktkrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #393 into master will increase coverage by 0.04%.
The diff coverage is 20.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #393      +/-   ##
============================================
+ Coverage     69.92%   69.96%   +0.04%     
- Complexity     2242     2246       +4     
============================================
  Files           301      301              
  Lines         13481    13488       +7     
  Branches       1116     1117       +1     
============================================
+ Hits           9426     9437      +11     
+ Misses         3690     3685       -5     
- Partials        365      366       +1     
Impacted Files Coverage Δ Complexity Δ
...rch/performanceanalyzer/config/SettingsHelper.java 20.00% <0.00%> (ø) 1.00 <0.00> (ø)
...ch/performanceanalyzer/PerformanceAnalyzerApp.java 60.16% <14.28%> (+1.76%) 15.00 <0.00> (+1.00)
...rch/performanceanalyzer/config/PluginSettings.java 33.04% <100.00%> (+1.18%) 15.00 <0.00> (-1.00) ⬆️
.../performanceanalyzer/rca/framework/api/Metric.java 76.19% <0.00%> (-4.77%) 8.00% <0.00%> (-1.00%)
...csearch/performanceanalyzer/rca/RcaController.java 83.00% <0.00%> (-0.98%) 46.00% <0.00%> (ø%)
...ceanalyzer/rca/framework/util/InstanceDetails.java 82.25% <0.00%> (+1.61%) 16.00% <0.00%> (+1.00%)
...o/elasticsearch/performanceanalyzer/core/Util.java 70.83% <0.00%> (+8.33%) 5.00% <0.00%> (ø%)
...lasticsearch/performanceanalyzer/ConfigStatus.java 83.33% <0.00%> (+83.33%) 4.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbb8e7...d33a983. Read the comment docs.

@sruti1312 sruti1312 dismissed stale reviews from ktkrg and sidheart via d33a983 August 24, 2020 22:33
@sruti1312 sruti1312 merged commit 864909e into master Aug 24, 2020
@sruti1312 sruti1312 deleted the partsrut-dependency branch August 24, 2020 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants