Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add IT for cache tuning #382

Merged
merged 5 commits into from
Aug 19, 2020
Merged

Add IT for cache tuning #382

merged 5 commits into from
Aug 19, 2020

Conversation

sruti1312
Copy link
Contributor

Issue #:

Description of changes:
This PR will add IT for cache cluster RCA (field data cache and shard request cache).
TODO: Add IT for decision maker & auto tuning piece in another PR.

Tests:
n/a

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sidheart sidheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please don't merge this until someone fixes RcaControllerTest#nodeRoleChange and this PR gets a green checkmark

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #382 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #382      +/-   ##
============================================
+ Coverage     69.73%   69.96%   +0.23%     
- Complexity     2236     2244       +8     
============================================
  Files           301      301              
  Lines         13436    13436              
  Branches       1115     1115              
============================================
+ Hits           9370     9401      +31     
+ Misses         3699     3676      -23     
+ Partials        367      359       -8     
Impacted Files Coverage Δ Complexity Δ
.../performanceanalyzer/rca/framework/api/Metric.java 76.19% <0.00%> (-4.77%) 8.00% <0.00%> (-1.00%)
...csearch/performanceanalyzer/rca/RcaController.java 83.00% <0.00%> (-0.98%) 46.00% <0.00%> (ø%)
...ceanalyzer/rca/framework/util/InstanceDetails.java 80.64% <0.00%> (ø) 15.00% <0.00%> (ø%)
...ceanalyzer/rca/store/rca/hotshard/HotShardRca.java 94.44% <0.00%> (+1.11%) 20.00% <0.00%> (+1.00%)
...search/performanceanalyzer/metrics/AllMetrics.java 91.95% <0.00%> (+2.06%) 0.00% <0.00%> (ø%)
...er/rca/store/rca/threadpool/QueueRejectionRca.java 96.05% <0.00%> (+2.63%) 14.00% <0.00%> (ø%)
...erformanceanalyzer/rca/scheduler/RCAScheduler.java 71.42% <0.00%> (+3.57%) 13.00% <0.00%> (+1.00%)
...zer/decisionmaker/deciders/CacheHealthDecider.java 91.30% <0.00%> (+4.34%) 22.00% <0.00%> (+2.00%)
...ecisionmaker/actions/ModifyCacheMaxSizeAction.java 82.35% <0.00%> (+7.84%) 21.00% <0.00%> (+3.00%)
.../rca/store/rca/util/NodeConfigCacheReaderUtil.java 65.00% <0.00%> (+15.00%) 5.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e10e0...19d0e5a. Read the comment docs.

@sruti1312 sruti1312 merged commit ea40b15 into master Aug 19, 2020
@sruti1312 sruti1312 deleted the partsrut-cache-tuning-it branch August 20, 2020 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants