This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fixing the summary serialization issue for cache RCAs #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rguo-aws
approved these changes
Aug 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
============================================
- Coverage 67.00% 66.98% -0.02%
+ Complexity 2034 2033 -1
============================================
Files 297 297
Lines 13140 13134 -6
Branches 1084 1083 -1
============================================
- Hits 8804 8798 -6
Misses 3948 3948
Partials 388 388
Continue to review full report at Codecov.
|
vigyasharma
reviewed
Aug 6, 2020
| InstanceDetails instanceDetails = getInstanceDetails(); | ||
| HotNodeSummary nodeSummary = new HotNodeSummary(instanceDetails.getInstanceId(), instanceDetails.getInstanceIp()); |
There was a problem hiding this comment.
So is the problem here a null HotNodeSummary ? Can we add UTs for a case where only few (or no) nodes have an issue?
yojs
approved these changes
Aug 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #347
Description of changes: Serialization failing for Cache RCAs because of
null HotNodeSummarywhen Resource is Healthy.Updated the default initialization and removed the Null assignment for
HotNodeSummaryBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.