This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add cache decider and modify cache action #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigyasharma
approved these changes
Jul 24, 2020
khushbr
approved these changes
Jul 25, 2020
|
|
||
| public class ModifyCacheCapacityAction implements Action { | ||
| public static final String NAME = "modifyCacheCapacity"; | ||
| public static final long COOL_OFF_PERIOD_IN_MILLIS = 300 * 1_000; |
There was a problem hiding this comment.
Will this setting be eventually moved to a yaml/config file?
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class ModifyCacheCapacityAction implements Action { |
There was a problem hiding this comment.
Let's add some javadoc here explaining what the class is trying to achieve.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Added a decider that determines if field data cache and shard request cache has to be modified.
Added an action to modify the caches.
Tests:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.