This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Rest mutual auth fix #279
Merged
Rest mutual auth fix #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidheart
force-pushed
the
rest-mutual-auth-fix
branch
from
a8865b5 to
b881fc8
Compare
added 6 commits
July 21, 2020 11:12
Previously we had 1 sided TLS on the server side. Data between the client and server was send over an encrypted channel, but any client could make requests to the server. This commit changes the behavior so that only clients with the matching certificates can make requests to the server when TLS is enabled. This commit does NOT add support for installing a trust manager. That must be added in the future.
This commit makes the PerformanceAnalyzerWebServer authenticate clients if the user specifies a certificate authority. It also properly sets up the server's identity, so that any clients can authenticate the server.
sidheart
force-pushed
the
rest-mutual-auth-fix
branch
from
67d53d5 to
8894129
Compare
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
============================================
+ Coverage 66.71% 67.16% +0.44%
- Complexity 1869 1882 +13
============================================
Files 276 276
Lines 12307 12338 +31
Branches 982 983 +1
============================================
+ Hits 8211 8287 +76
+ Misses 3764 3718 -46
- Partials 332 333 +1
Continue to review full report at Codecov.
|
ktkrg
approved these changes
Jul 24, 2020
| * ClientAuthConfigurator makes the server perform client authentication if the user has set up a | ||
| * certificate authority | ||
| */ | ||
| private static class ClientAuthConfigurator extends HttpsConfigurator { |
There was a problem hiding this comment.
nit: additional space. static class -> static class
|
One more thing, can you link the issue by changing |
yojs
approved these changes
Jul 27, 2020
| server.setHttpsConfigurator(new ClientAuthConfigurator(sslContext)); | ||
|
|
||
|
|
||
| // TODO ask ktkrg why this is necessary |
There was a problem hiding this comment.
Do you plan to wrap up the TODO in this PR or in a follow up ?
yojs
approved these changes
Jul 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #278
Description of changes: Adds configurable auth to REST endpoints
Tests: TestNetServer
Code coverage percentage for this patch: See CodeCov report
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.