This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add opendistro_security.cookie.secure: false to service scripts settings for TAR/DEB/RPM/DOCKER/WINDOWS #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs for TAR/DEB/RPM/DOCKER/WINDOWS
camerski
approved these changes
Sep 23, 2020
gaiksaya
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/opendistro-for-elasticsearch/opendistro-infra/issues/251
Description of changes:
Add opendistro_security.cookie.secure: false to service scripts settings for TAR/DEB/RPM/DOCKER/WINDOWS
This is a follow-up PR to #397
Service script will add this settings no matter what
It will not take effect in security kibana 1.0 framework, and it will take effects if it does not present in security kibana 2.0 framework already
Test Results:
No way to test as integration test does not allow us to access 5601 port on github runners
Note: If this PR is related to Helm, please also update the README for related documentation changes. Thanks.
https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/helm/README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.