Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update artifact naming #309

Merged

Conversation

jmazanec15
Copy link
Member

Issue #, if available:

Description of changes:
This PR updates the k-NN plugins artifacts with the naming conventions set by the infrastructure team.

The new artifacts look like this:

opendistro-knn-1.12.0.0.rpm
opendistro-knn-1.12.0.0.deb
opendistro-knnlib-1.12.0.0-linux-arm64.deb
opendistro-knnlib-1.12.0.0-linux-arm64.rpm
opendistro-knnlib-1.12.0.0-linux-x64.deb
opendistro-knnlib-1.12.0.0-linux-x64.rpm

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added the Infrastructure Change releated to distribution of plugin label Jan 25, 2021
@jmazanec15 jmazanec15 changed the title Artifact naming Update artifact naming Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #309 (383cb6e) into master (b34f930) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #309   +/-   ##
=========================================
  Coverage     80.51%   80.51%           
  Complexity      388      388           
=========================================
  Files            62       62           
  Lines          1468     1468           
  Branches        130      130           
=========================================
  Hits           1182     1182           
  Misses          239      239           
  Partials         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34f930...383cb6e. Read the comment docs.

jni/CMakeLists.txt Outdated Show resolved Hide resolved
@VijayanB
Copy link
Member

@jmazanec15 Will the updated name appears in github checks now?

@jmazanec15
Copy link
Member Author

@jmazanec15 Will the updated name appears in github checks now?

Yes workflows will still work. We use wildcards for picking up names. For example, https://github.com/opendistro-for-elasticsearch/k-NN/blob/master/.github/workflows/CD.yml#L58-L60

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazanec15 jmazanec15 merged commit d4b1ae4 into opendistro-for-elasticsearch:master Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure Change releated to distribution of plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants