This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Upgrade commons-beanutils #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
============================================
+ Coverage 80.44% 80.51% +0.06%
- Complexity 387 388 +1
============================================
Files 62 62
Lines 1468 1468
Branches 130 130
============================================
+ Hits 1181 1182 +1
+ Misses 240 239 -1
Partials 47 47
Continue to review full report at Codecov.
|
jmazanec15
reviewed
Jan 5, 2021
Was referring Performance Analyzer plugin opendistro-for-elasticsearch/performance-analyzer#248. With out adding the xml file, checkstyle fails at compilation. |
jmazanec15
approved these changes
Jan 14, 2021
VijayanB
reviewed
Jan 15, 2021
| <?xml version="1.0"?> | ||
| <!DOCTYPE module PUBLIC | ||
| "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" | ||
| "https://checkstyle.org/dtds/configuration_1_3.dtd"> |
There was a problem hiding this comment.
do we generally not add Apache 2.0 copyright notice in xml files? i don't find in performance analyzer too.
VijayanB
approved these changes
Jan 15, 2021
VijayanB
added
the
Maintenance
VijayanB
added
Enhancements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#269
Description of changes:
commons-beanutils:commons-beanutils:1.9.3is coming fromcom.puppycrawl.tools:checkstyle:8.20. Added 'com.puppycrawl.tools:checkstyle:8.24' dependency. Also, added checkstyle.xmlPost update
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.