This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
NPE in force merge when non knn doc gets updated to knn doc across segments #212
Merged
vamshin
merged 10 commits into
opendistro-for-elasticsearch:master
from
vamshin:master-merge-fix
Sep 4, 2020
Merged
NPE in force merge when non knn doc gets updated to knn doc across segments #212
vamshin
merged 10 commits into
opendistro-for-elasticsearch:master
from
vamshin:master-merge-fix
Sep 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
+ Coverage 76.95% 77.34% +0.39%
- Complexity 302 307 +5
============================================
Files 50 50
Lines 1189 1192 +3
Branches 100 101 +1
============================================
+ Hits 915 922 +7
+ Misses 225 221 -4
Partials 49 49
Continue to review full report at Codecov.
|
jmazanec15
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
vamshin
changed the title
NPE in force merge when non knn doc gets updated to knn doc
NPE in force merge when non knn doc gets updated to knn doc across segments
Sep 4, 2020
vamshin
added a commit
that referenced
this pull request
Sep 4, 2020
…gments (#212) * force merge NPE when non knn doc updated to knn doc
vamshin
added a commit
that referenced
this pull request
Sep 4, 2020
…gments (#212) * force merge NPE when non knn doc updated to knn doc
vamshin
added a commit
that referenced
this pull request
Sep 4, 2020
…gments (#212) * force merge NPE when non knn doc updated to knn doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#210
Description of changes:
NPE occurs forcemerge when non knn doc gets updated to knn doc. This happens when a a doc in non knn in one segment and gets updated to knn doc in another segment and forcemerge occurs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.