Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

NPE in force merge when non knn doc gets updated to knn doc across segments #212

Merged
merged 10 commits into from
Sep 4, 2020

Conversation

vamshin
Copy link
Member

@vamshin vamshin commented Sep 4, 2020

Issue #, if available:
#210

Description of changes:
NPE occurs forcemerge when non knn doc gets updated to knn doc. This happens when a a doc in non knn in one segment and gets updated to knn doc in another segment and forcemerge occurs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #212 into master will increase coverage by 0.39%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     76.95%   77.34%   +0.39%     
- Complexity      302      307       +5     
============================================
  Files            50       50              
  Lines          1189     1192       +3     
  Branches        100      101       +1     
============================================
+ Hits            915      922       +7     
+ Misses          225      221       -4     
  Partials         49       49              
Impacted Files Coverage Δ Complexity Δ
...n/index/codec/KNN80Codec/KNN80DocValuesReader.java 75.00% <75.00%> (+5.76%) 5.00 <0.00> (+2.00)
...relasticsearch/knn/index/KNNVectorFieldMapper.java 79.28% <0.00%> (+1.42%) 17.00% <0.00%> (+2.00%)
...index/codec/KNN80Codec/KNN80DocValuesConsumer.java 65.82% <0.00%> (+2.53%) 12.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71bc1b...6811a4e. Read the comment docs.

Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jmazanec15 jmazanec15 added the Bug Fixes Change that fixes a bug label Sep 4, 2020
@vamshin vamshin changed the title NPE in force merge when non knn doc gets updated to knn doc NPE in force merge when non knn doc gets updated to knn doc across segments Sep 4, 2020
@vamshin vamshin merged commit f7557f2 into opendistro-for-elasticsearch:master Sep 4, 2020
vamshin added a commit that referenced this pull request Sep 4, 2020
…gments (#212)


* force merge NPE when non knn doc updated to knn doc
vamshin added a commit that referenced this pull request Sep 4, 2020
…gments (#212)


* force merge NPE when non knn doc updated to knn doc
vamshin added a commit that referenced this pull request Sep 4, 2020
…gments (#212)


* force merge NPE when non knn doc updated to knn doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fixes Change that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants