Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Use ROOT Locale for Strings #14

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Jun 14, 2019

Issue #, if available:

Description of changes:
Use Locale.ROOT for Strings to prevent inconsistencies in format

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jinsoor-amzn jinsoor-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NİCE FİX 👍

@qreshi qreshi merged commit c0d1706 into opendistro-for-elasticsearch:master Jun 14, 2019
dbbaughe added a commit that referenced this pull request Jun 21, 2019
* Adds equals, hashCode, toString overrides to IntervalSchedule and CronSchedule (#13)

* Use ROOT Locale for Strings to prevent inconsistencies in format (#14)

* update ScheduledJobParser to use the JobDocVersion (#15)

* update ScheduledJobParser to use the JobDocVersion

* Bump version to 1.0.0.1
dbbaughe added a commit that referenced this pull request Feb 20, 2020
* Updated README.md w spelling correction

* Uses primary_term/seq_no for job doc versioning

*  support scheduledJob with locks. (#8)

* support scheduledJob with locks.

* Use ClusterService instead of Client to check the index exists.

address some minor comment.

* Updated through the comment.

1. Move the LockService in the SPI package
1. Added deleteLock to test.
1. Updated naming from job_type to job_index_name
1. updated delete lock to be safe with non existing index name.

* Use ClusterStateService for lockIndexExist

* Update acquireLock to take JobParam and JobContext

* add some documentation to LockService

* Fixes access denied issue and testing randomly failing because if es test framework

* Debian package build

* Refactor JobSweeper to do sweep on certain clusterChangedEvent (#10)

* Filter clusterChangedEvent when doing sweeping
* Format code

* Change log level when sweeper already have latest job version (#11)

* Update release lock log level
* Update sweeper version compare log level

* Override equals and hashCode for LockModel (#12)

* Adds equals, hashCode, toString overrides to IntervalSchedule and CronSchedule (#13)

* Use ROOT Locale for Strings to prevent inconsistencies in format (#14)

* update ScheduledJobParser to use the JobDocVersion (#15)

* update ScheduledJobParser to use the JobDocVersion

* Fixes byte charset default

* Add maven publish task for spi (#23)

* Add spi subproject maven publish task

* Converts lock service to async

* Updates lockservice to work in 6.8

* Updates plugin version and updates release notes

Co-authored-by: Alolita Sharma <[email protected]>
Co-authored-by: Jinsoo <[email protected]>
Co-authored-by: Yan Zeng <[email protected]>
Co-authored-by: Mohammad Qureshi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants