This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fixes snapshot bugs #244
Merged
Fixes snapshot bugs #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tus check exhaustive
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
============================================
+ Coverage 70.80% 71.12% +0.31%
- Complexity 605 615 +10
============================================
Files 83 83
Lines 3552 3584 +32
Branches 587 593 +6
============================================
+ Hits 2515 2549 +34
+ Misses 740 729 -11
- Partials 297 306 +9
Continue to review full report at Codecov.
|
|
codecov/path failing because of coverage of the extra branches added in the logic. |
qreshi
approved these changes
Jun 25, 2020
bowenlan-amzn
approved these changes
Jun 25, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Jul 29, 2020
* Simplifies snapshot message * Handle ConcurrentSnapshotExecutionExceptions during remote transport calls * Adds try/catch block around WaitForSnapshotStep execute * Fixes snapshot completed check including failed/aborted and makes status check exhaustive * Adds snapshot name to ActionProperties * Uses snapshotName in ActionProperties in snapshot steps * Adds a couple more integration tests for snapshot action * Suppress complex method in execute step
dbbaughe
added a commit
that referenced
this pull request
Jul 29, 2020
* Fixes snapshot bugs (#244) * Simplifies snapshot message * Handle ConcurrentSnapshotExecutionExceptions during remote transport calls * Adds try/catch block around WaitForSnapshotStep execute * Fixes snapshot completed check including failed/aborted and makes status check exhaustive * Adds snapshot name to ActionProperties * Uses snapshotName in ActionProperties in snapshot steps * Adds a couple more integration tests for snapshot action * Suppress complex method in execute step * Fixes snapshot issues, adds history mapping update workflow, adds tests (#255) * Fixes snapshot issues, adds history mapping update workflow, adds tests * Adds a couple more tests for the destination parsing tests * Removes unneeded line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#240
Description of changes:
There were a few bugs found in snapshot from the #240 issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.