This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adds rollover conditions into info object #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsoor-amzn
approved these changes
Apr 24, 2020
zengyan-amazon
approved these changes
Apr 24, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#271) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#272) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#273) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#274) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#275) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#276) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#277) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#171
Description of changes:
This solves half of above issue by showing the rollover conditions in the info object. Transitions will be done at a later time.
We are getting a lot of questions on "why" did the managed index rollover or not rollover. We added some logs but that was only for when it actually does rollover. This now covers both and makes it easy to see exactly why it rolled over (or didn't).
If no conditions are specified then no conditions object will be shown in info (there is an assertion added for this in the tests).
And the conditions will only be shown if they were specified by the user, i.e. if user only chooses to rollover on doc count then only doc count conditions will be shown.
Example images:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.