This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Delete and close failing during snapshot in progress #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbbaughe
changed the title
jinsoor-amzn
reviewed
Apr 3, 2020
...in/com/amazon/opendistroforelasticsearch/indexstatemanagement/step/close/AttemptCloseStep.kt
Show resolved
Hide resolved
...lin/com/amazon/opendistroforelasticsearch/indexstatemanagement/step/AttemptCloseStepTests.kt
Show resolved
Hide resolved
jinsoor-amzn
approved these changes
Apr 3, 2020
qreshi
approved these changes
Apr 6, 2020
bowenlan-amzn
approved these changes
Apr 6, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
Merged
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
Merged
dbbaughe
added a commit
that referenced
this pull request
Apr 6, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
that referenced
this pull request
Apr 6, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Apr 6, 2020
…elasticsearch#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
dbbaughe
added a commit
that referenced
this pull request
Apr 7, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling * Fixes CloseIndexResponse init * Fixes test to use Ack response * Fixes ack value
dbbaughe
added a commit
that referenced
this pull request
Apr 7, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling * Fixes CloseIndexResponse init * Fixes missed merge conflict * Fixes tests
dbbaughe
added a commit
that referenced
this pull request
Apr 7, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling * Fixes CloseIndexResponse init * Fixes missed merge conflict * Fixes tests
dbbaughe
added a commit
that referenced
this pull request
Apr 7, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling * Fix CloseIndexResponse init
dbbaughe
added a commit
that referenced
this pull request
Apr 7, 2020
* Adds logs, fix for index creation date -1L, nullable checks (#170) * Index creation_date of -1L should evaluate to false, adds extra logs * Adds kotlin compiler check and fixes nullable values * Adds log * Delete and close failing during snapshot in progress (#172) * Fixes AttemptDeleteStep failing from a SnapshotInProgressException * Fixes close action failing on snapshot in progress exception, fixes imports * Fixes styling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently DeleteAction and CloseAction will treat a SnapshotInProgressException as a failure that will consume action retries or fail if none.
These should be treated as noops instead and allowed to retry automatically.
Checked here to see where this exception can come from and only found Delete and Close.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.