Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add brace dep for binary kibana not starting problem #96

Merged
merged 1 commit into from
Jun 30, 2020
Merged

add brace dep for binary kibana not starting problem #96

merged 1 commit into from
Jun 30, 2020

Conversation

bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Jun 30, 2020 •
edited
Loading

Issue #, if available:

Description of changes:
Thanks to @ohltyler fix for binary kibana not starting problem

  • add brace dependency in package.json

tested locally with binary Kibana OSS, can start with this version now

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dbbaughe
dbbaughe approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@dbbaughe dbbaughe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to backport to the opendistro-1.9 branch don't forget to bump the plugin version #/tag

@bowenlan-amzn bowenlan-amzn merged commit 34cafc7 into opendistro-for-elasticsearch:master Jun 30, 2020
@bowenlan-amzn bowenlan-amzn deleted the add-brace-dep branch June 30, 2020 16:37
@bowenlan-amzn bowenlan-amzn restored the add-brace-dep branch June 30, 2020 16:46
bowenlan-amzn added a commit that referenced this pull request Jun 30, 2020
@bowenlan-amzn
backport to branch 1.9: add brace dep for binary kibana not starting …
4587a5f 
…problem (#97)

* add brace dep for binary kibana not starting problem (#96)

* bump ODFE version to 1.9.0.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ftianli-amzn ftianli-amzn ftianli-amzn approved these changes

@dbbaughe dbbaughe dbbaughe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowenlan-amzn @dbbaughe @ftianli-amzn