This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Modify getRollups API to use getRollup instead of search API #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 22, 2020 14:33
|
Test Suites: 32 passed, 32 total |
annie3431
requested review from
bowenlan-amzn,
dbbaughe,
ftianli-amzn and
qreshi
ftianli-amzn
previously approved these changes
Jan 5, 2021
qreshi
previously approved these changes
Jan 5, 2021
dbbaughe
reviewed
Jan 5, 2021
server/services/RollupService.ts
Outdated
| }); | ||
| return response.custom({ | ||
| statusCode: 200, | ||
| body: { ok: true, response: { rollups: rollups, totalRollups: totalRollups, metadata: explainResponse } }, | ||
| body: { ok: true, response: { rollups: rollups, total_rollups: totalRollups, metadata: explainResponse } }, |
There was a problem hiding this comment.
Any reason for changing this to snake_case?
There was a problem hiding this comment.
It was a few changes after adding type definition of GetRollupsResponse in line 293, the interface definition was changed to snake_case, too.
Since other functions does not define the type of received response, had just removed the type definition in line 292 making it const getRollupResponse = await ... and changed snake_case back to camelCase.
dbbaughe
approved these changes
Jan 5, 2021
ftianli-amzn
approved these changes
Jan 5, 2021
bowenlan-amzn
added
refactor
and removed
maintenance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Add new route
getRollupsinismPlugins.tsChange
totalRolluptototal_rollupsingetRollupsResponseinterface to match with backend response.Previously
getRollupsis using search API to fetch multiple rollup jobs. Now changed to usegetRollupand passing in parameters:from,size,search,sortField, andsortDirection.Modify
getRollupsto fetch metadata of all rollup jobs by directly requesting fromism.explainRollup, and removed previously defined functionexplainRollup.A few updates on interface definitions to reduce mismatch type errors
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.