This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix null pointer exception during preview #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we changed the anomaly result index’s schema and toXContent method by introducing a few fields. During the preview, some of the fields in anomaly result index can be null. Thus, toXContent can fail with a null pointer exception. This PR fixes the issue by protecting a field’s serialization with a null check. Testing done: - Manually verified the issue is gone - gradle build
kaituo
changed the title
wnbts
approved these changes
Mar 23, 2020
ylwu-amzn
approved these changes
Mar 24, 2020
We may need integration test to find these errors as this requires basically all of the preview components to run to expose this bug. Will create integration test in this package later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#73
Description of changes:
Recently, we changed the anomaly result index’s schema and toXContent method by introducing new fields. During the preview, some of the fields in anomaly result index are null. Thus, toXContent fails with a null pointer exception.
This PR fixes the issue by protecting a field’s serialization with a null check.
This PR also removes an unused local variable in ModelManager.
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.