This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Send back error response when failing to stop detector #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a stop detector api request hangs until timeout if there is a failure. Testing done: * verified the issue is fixed
ylwu-amzn
reviewed
Feb 20, 2020
| @@ -133,6 +133,7 @@ public void onResponse(StopDetectorResponse stopDetectorResponse) { | |||
| @Override | |||
| public void onFailure(Exception e) { | |||
| logger.error("Failed to delete AD model for detector " + detectorId, e); | |||
| channel.sendResponse(new BytesRestResponse(RestStatus.INTERNAL_SERVER_ERROR, "Failed to delete AD model")); | |||
There was a problem hiding this comment.
Thanks for this fix.
We will add AD job and the stop detector API will not be called when delete monitor. Have moved stop detector logic to stop AD job API in this PR: #44
There was a problem hiding this comment.
I see. Will close this PR and comment on your PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a stop detector api request hangs until timeout if there is a failure.
Testing done: