This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix nested field issue #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our validation logic cannot parse nested fields from the getFieldMapping response because nested fields don't have the full name in the response. For example, the field nested_host.host only has "host" in the type mapping instead of "nested_host.host". This PR fixes that by not depending on field name when parsing the name type mapping. Testing done: 1. manual testing passes.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
============================================
- Coverage 73.29% 73.25% -0.04%
- Complexity 1751 1752 +1
============================================
Files 180 180
Lines 8119 8122 +3
Branches 670 672 +2
============================================
- Hits 5951 5950 -1
- Misses 1859 1863 +4
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Have manually confirmed this works for both flat and nested category fields. |
ylwu-amzn
approved these changes
Oct 19, 2020
yizheliu-amazon
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Previously, our validation logic cannot parse nested fields from the getFieldMapping response because nested fields don't have the full name in the response. For example, the field nested_host.host only has "host" in the type mapping instead of "nested_host.host". This PR fixes that by not depending on field name when parsing the name type mapping.
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.