Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Include release notes for 1.10.0.0 #219

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

VijayanB
Copy link
Member

Added release notes with categories and corresponding PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added release notes with categories and corresponding PR.
@VijayanB VijayanB self-assigned this Aug 25, 2020
@VijayanB VijayanB added the documentation Improvements or additions to documentation label Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #219 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     72.36%   72.45%   +0.08%     
- Complexity     1288     1291       +3     
============================================
  Files           139      139              
  Lines          6073     6073              
  Branches        469      469              
============================================
+ Hits           4395     4400       +5     
+ Misses         1465     1461       -4     
+ Partials        213      212       -1     
Flag Coverage Δ Complexity Δ
#cli 80.30% <ø> (ø) 0.00 <ø> (ø)
#plugin 71.40% <ø> (+0.09%) 1291.00 <ø> (+3.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...sticsearch/ad/indices/AnomalyDetectionIndices.java 63.76% <0.00%> (+2.17%) 25.00% <0.00%> (+2.00%)
...asticsearch/ad/cluster/ADClusterEventListener.java 92.00% <0.00%> (+4.00%) 14.00% <0.00%> (+1.00%)

@@ -0,0 +1,37 @@
## Version 1.10.0.0 Release Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An observation from an ODFE user (posted on our discussion forum), the download links used in plugin packages are incorrect. Requesting all plugin owners to correct it, if artifacts not published yet.
What it is:

https://opendistro.github.io/elasticsearch/downloads
What it should be:

https://opendistro.github.io/for-elasticsearch/downloads.html
Where to change: In build.gradle file
Example: https://github.com/opendistro-for-elasticsearch/anomaly-detection/blob/master/build.gradle#L347

Can you modify as mentioned above in your release PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure.

Update url to valid location.
Copy link
Contributor

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding!

@VijayanB VijayanB merged commit 7e62e1c into opendistro-for-elasticsearch:master Aug 25, 2020
@VijayanB VijayanB deleted the release-notes branch August 25, 2020 22:19

### Features

* AD CLI ([#196](https://github.com/opendistro-for-elasticsearch/anomaly-detection/pull/196))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are going to release AD CLI along with 1.10?

### Features

* AD CLI ([#196](https://github.com/opendistro-for-elasticsearch/anomaly-detection/pull/196))
* Get detector ([#207](https://github.com/opendistro-for-elasticsearch/anomaly-detection/pull/207))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we make the description more clear ? Like "Get detector command in AD CLI tool"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants