This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve ux #209
Merged
Improve ux #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove esad.
Instead of displaying headers with empty list, show message with hints.
For readability, move constants based on alphabetically.
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 72.18% 72.15% -0.04%
+ Complexity 1275 1274 -1
============================================
Files 140 140
Lines 5914 5914
Branches 463 463
============================================
- Hits 4269 4267 -2
- Misses 1441 1442 +1
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
reviewed
Aug 11, 2020
| FlagEndpoint = "endpoint" | ||
| FlagPassword = "password" |
There was a problem hiding this comment.
generally in cli,
the action is called command eg: esad / aws-cli / ls / git
options are called flags or parameters like "git --config" / "git checkout -b branch name ( config and b are flags/parameters)
There was a problem hiding this comment.
I see. I thought there might be some special meaning.
kaituo
approved these changes
Aug 11, 2020
ylwu-amzn
approved these changes
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.