Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Create RFC for AD CLI #185

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Jul 9, 2020

This is the RFC for the Anomaly Detection CLI feature to be built on AD.

Issue #, if available:
N/A

Description of changes:
Created RFC to get feedback from community

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@VijayanB VijayanB self-assigned this Jul 9, 2020
@ylwu-amzn
Copy link
Contributor

Can't add comments on pdf file. How about change to markdown ?

@VijayanB VijayanB force-pushed the rfc-adcli branch 2 times, most recently from 0bb456f to 5240029 Compare July 9, 2020 20:03
@wnbts
Copy link
Contributor

wnbts commented Jul 9, 2020

question. how does a user provide comments?

my comments. All anomaly detection functionality is available via rest api. A notebook containing example code for common cases might be another flexible and scalable option.

@VijayanB VijayanB force-pushed the rfc-adcli branch 4 times, most recently from 6659f59 to 3df1a04 Compare July 9, 2020 20:33
This is the RFC for the Anomaly Detection CLI feature to be built on AD.
@VijayanB
Copy link
Member Author

VijayanB commented Jul 9, 2020

@ylwu-amzn Like @wnbts mentioned we will add this(PR) to our odfe roadmap to get feedback.
Nevertheless. i exported to markdown to keep it consistent with read me file.

cli/rfc-adcli.md Outdated

### Request for Comments:

We would like comments and feedback on the proposal for building AD CLI tool. Some specific questions we’re seeking feedback include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we put a Github issue link here, so community can add comments easily.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue and included the link.

@VijayanB VijayanB requested a review from ylwu-amzn July 9, 2020 21:21
Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@VijayanB VijayanB merged commit 4bf1818 into opendistro-for-elasticsearch:master Jul 9, 2020
@yizheliu-amazon yizheliu-amazon added the documentation Improvements or additions to documentation label Aug 5, 2020
yizheliu-amazon pushed a commit that referenced this pull request Aug 28, 2020
* Create RFC for AD CLI

This is the RFC for the Anomaly Detection CLI feature to be built on AD.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants