This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support security plugin enabled testing in CI #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to support integration testing against remote security-enabled clustering in our CI. Currently, we only support the integration testing without a security plugin and have to remove the security plugin in CI. The critical change is to create an https client with basic auth in ODFERestTestCase and let our rest test case inherit from ODFERestTestCase. With default security configuration, the password for the admin user is also “admin.” For ssl certification, we choose to disable it since it’s the default demo cert used here. Testing done: * ran the scripts on CI/CD workflow on Mac and tested it works. * gradle build still passes.
src/test/java/com/amazon/opendistroforelasticsearch/ad/ODFERestTestCase.java
Outdated
Show resolved
Hide resolved
weicongs-amazon
approved these changes
Jun 30, 2020
| if (isHttps) { | ||
| // currently only external cluster is supported for security enabled testing | ||
| if (!Optional.ofNullable(System.getProperty("tests.rest.cluster")).isPresent()) { | ||
| throw new RuntimeException("external cluster url should be provided for security enabled testing"); |
There was a problem hiding this comment.
external might be confusing as in the CI we are actually using localhost. Maybe we can just say "cluster url should be provided for security enabled testing"
yizheliu-amazon
approved these changes
Jun 30, 2020
yizheliu-amazon
pushed a commit
that referenced
this pull request
Aug 28, 2020
* Support security plugin enabled testing in CI This change is to support integration testing against remote security-enabled clustering in our CI. Currently, we only support the integration testing without a security plugin and have to remove the security plugin in CI. The critical change is to create an https client with basic auth in ODFERestTestCase and let our rest test case inherit from ODFERestTestCase. With default security configuration, the password for the admin user is also “admin.” For ssl certification, we choose to disable it since it’s the default demo cert used here. Testing done: * ran the scripts on CI/CD workflow on Mac and tested it works. * gradle build still passes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#142
Description of changes:
This change is to support integration testing against remote security-enabled clustering in our CI. Currently, we only support the integration testing without a security plugin and have to remove the security plugin in CI.
The critical change is to create an https client with basic auth in ODFERestTestCase and let our rest test case inherit from ODFERestTestCase. With default security configuration, the password for the admin user is also “admin.” For ssl certification, we choose to disable it since it’s the default demo cert used here.
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.