Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Rollover AD result index less frequently #168

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Rollover AD result index less frequently #168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
142688c
Rollover AD result index less frequently
kaituo Jun 20, 2020
ac3bc59
Update comments
kaituo Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/amazon/opendistroforelasticsearch/ad/settings/AnomalyDetectorSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private AnomalyDetectorSettings() {}
// Suppose generally per cluster has 200 detectors and all run with 1 minute interval.
// We will get 288,000 AD result docs. So set it as 300k to avoid multiple roll overs
// per day.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor. comments are outdated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

300 * 1000L,
9_000_000L,
Copy link
Member

@vamshin vamshin Jun 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a problem for 200 detectors? From the comment 300k is taking care of 288k limit to avoid multiple roll overs right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not a problem for 200 detectors. It is a problem of small shard. Please see my PR descriptions.

Copy link
Member

@vamshin vamshin Jun 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right i get that. Comment is misleading here. Why not mention the message in PR description as comment? We are talking about 200 detectors and roll overs in the comment. Atleast mention the PR?

One more thing you might want to confirm is does having larger index impact performance when compared to previous smaller index?

0L,
Setting.Property.NodeScope,
Setting.Property.Dynamic
Expand Down