This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Forward porting "Fix that AD job cannot be terminated due to missing training data" #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endistro-for-elasticsearch#102) We expect an EndRunException to be thrown due to missing training data. But the exception is not appropriately propagated back to AD job and results in InternalFailure instead. This PR fixes the bug. Testing done: 1. Manually reproduced all possible EndRunExceptions, check AD job is terminated, and check profile API status is correct. 2. Added unit tests to expose the bug.
ylwu-amzn
approved these changes
May 19, 2020
yizheliu-amazon
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR forward porting b351d40
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.