Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix sunburst chart not resolved; fix data loading on dashboard #73

Conversation

yizheliu-amazon
Copy link
Contributor

Issue #, if available:

Description of changes:
Fix the bug of getting data request time out for sunburst chart on dashboard
Fix sunburst chart not resolved.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -29,7 +29,7 @@ import {
//@ts-ignore
EuiStat,
} from '@elastic/eui';
import { Chart, Partition, PartitionLayout } from '@elastic/charts';
import { Chart, Partition, PartitionLayout } from '@elastic/charts/dist/index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, after I had pulled all of our latest changes I never ran into this issue again... you were getting this issue with 7.6.1 kibana oss?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use code from here, but I run yarn start --no-base-path --oss. Will that make a difference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm no, I was doing the same. if you still encounter the issue i agree we should add this

Copy link
Contributor

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change!

@yizheliu-amazon yizheliu-amazon merged commit f95faf2 into opendistro-for-elasticsearch:master May 1, 2020
@yizheliu-amazon yizheliu-amazon deleted the fix-dist-chart branch May 1, 2020 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants