This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Migrate entire plugin to new platform #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
added
the
version upgrade
ohltyler
requested review from
ylwu-amzn,
yizheliu-amazon,
saratvemulapalli,
kaituo and
ftianli-amzn
yizheliu-amazon
approved these changes
Nov 18, 2020
ylwu-amzn
reviewed
Nov 20, 2020
ylwu-amzn
reviewed
Nov 20, 2020
kibana.json
Outdated
| "kibanaVersion": "7.9.1", | ||
| "configPath": ["opendistro_anomaly_detection_kibana"], | ||
| "requiredPlugins": ["navigation"], | ||
| "optionalPlugins": ["opendistro-alerting", "opendistro_alerting"], |
There was a problem hiding this comment.
Why add two alerting plugins?
There was a problem hiding this comment.
This was the naming conventions for the ES and Kibana alerting plugins. With the new naming conventions for the Kibana plugin this will need to be revisited, I'll make a note of it. Also, adding optional plugins doesn't really have much functionality at all, and we could remove altogether. See here
ylwu-amzn
reviewed
Nov 20, 2020
ylwu-amzn
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR migrates the entire plugin to the new Kibana platform, which is required for Kibana 7.10. A follow up PR will be made to upgrade the plugin to 7.10. Overview of the changes can be found here.
The main changes include:
indexandpluginfiles for eachkibana.jsonmanifest fileIHttpServiceto Kibana's coreHttpSetupclient, and changing all request/response parsing logic accordinglyIClusterClientwith all of the services, and changing the different route functions to be grouped into different service classesui/*statements, and accessing core services (chrome breadcrumbs, toast notifications, etc.) by consuming them via React contextNotes:
yarn startin the plugin repo anymore - need to run in base Kibana dirKnown issues:
yarn buildissues - the built artifact won't work with the binary Kibana. This is fixed separately, will be included in a follow up PRTask backlog:
yarncommand changesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.