This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Query anomaly only for HC detector #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizheliu-amazon
requested review from
ylwu-amzn,
weicongs-amazon and
ohltyler
ohltyler
approved these changes
Oct 22, 2020
weicongs-amazon
approved these changes
Oct 22, 2020
ylwu-amzn
approved these changes
Oct 22, 2020
ylwu-amzn
added
the
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Query anomaly only for HC detector. This is for issue found during performance test: in current implementation, if there are over 10K(our upper limit) anomaly results during query time range, we only get 10K results, including both 0 and >0 result, so that we may miss anomalies with grade > 0. It is easy to get into such case for HC detector.
And actually HC detector for now only uses anomalyResults with grade > 0, thus I change to only get anomalyResults with grade > 0 for HC detector to avoid above case.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.