This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix bug where undefined is shown on UI for estimatedMins in case of ingestion data missing #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngestion data missing
yizheliu-amazon
requested review from
saratvemulapalli,
ylwu-amzn and
ohltyler
|
will cherry-pick it to 1.10, 1.9 |
ylwu-amzn
reviewed
Sep 3, 2020
| return detector && isDetectorInitializing && detector.initProgress | ||
| return detector && | ||
| isDetectorInitializing && | ||
| detector.initProgress && |
There was a problem hiding this comment.
Use lodash get ?
get(detector, 'initProgress. estimatedMinutesLeft')
There was a problem hiding this comment.
good idea, probably many places within this page and other places in the plugin where we should change to use lodash get to make it simpler
|
Small: can you manually add to 1.10 release notes? |
good point. will add it. |
ohltyler
approved these changes
Sep 3, 2020
ylwu-amzn
approved these changes
Sep 3, 2020
yizheliu-amazon
added a commit
that referenced
this pull request
Sep 3, 2020
…ngestion data missing (#301) * Fix bug where undefined is shown on UI for estimatedMins in case of ingestion data missing
yizheliu-amazon
added a commit
that referenced
this pull request
Sep 3, 2020
…ngestion data missing (#301) * Fix bug where undefined is shown on UI for estimatedMins in case of ingestion data missing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix bug where undefined is shown on UI for estimatedMins in case of ingestion data missing
Before
After
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.