Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add sample detectors and indices #295

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add sample detectors and indices #295

merged 1 commit into from
Sep 2, 2020

Conversation

ohltyler
Copy link
Contributor

@ohltyler ohltyler commented Sep 1, 2020

Issue #, if available:

Description of changes:

Backporting sample detectors to opendistro-1.10 branch to include in ODFE 1.10.0 release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ohltyler ohltyler changed the title Add sample detectors and indices (#272) Add sample detectors and indices Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #295 into opendistro-1.10 will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           opendistro-1.10     #295      +/-   ##
===================================================
- Coverage            42.53%   42.24%   -0.30%     
===================================================
  Files                  108      117       +9     
  Lines                 2586     2831     +245     
  Branches               310      321      +11     
===================================================
+ Hits                  1100     1196      +96     
- Misses                1429     1578     +149     
  Partials                57       57              
Flag Coverage Δ
#unittests 42.24% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bana-plugin/public/redux/reducers/elasticsearch.ts 54.76% <0.00%> (-19.32%) ⬇️
...-detection-kibana-plugin/public/utils/constants.ts 100.00% <0.00%> (ø)
...detection-kibana-plugin/public/pages/main/Main.tsx 0.00% <0.00%> (ø)
...ction-kibana-plugin/public/pages/utils/SideBar.tsx 0.00% <0.00%> (ø)
...tion-kibana-plugin/public/pages/utils/constants.ts 100.00% <0.00%> (ø)
...in/public/components/ContentPanel/ContentPanel.tsx 50.00% <0.00%> (ø)
...ages/DetectorResults/containers/AnomalyResults.tsx 0.00% <0.00%> (ø)
...-kibana-plugin/public/redux/reducers/sampleData.ts 36.36% <0.00%> (ø)
...onents/SampleDetailsFlyout/SampleDetailsFlyout.tsx 9.09% <0.00%> (ø)
...eIndexDetailsCallout/SampleIndexDetailsCallout.tsx 50.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c865e1...2c61f5c. Read the comment docs.

Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the backporting.

@ohltyler ohltyler merged commit 444e4e3 into opendistro-1.10 Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants