This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #258
Description of changes:
snakeCase will replace "." with "_", that may make preview not work when the field name contains "."
User reported preview can't work: opendistro-for-elasticsearch/anomaly-detection#192.
User used field name "host.name" in filter query, but snakeCase will transform it into "host_name" which is an invalid field name. So preview function can't get any data.
We need to exclude detector in preview input when convert keys to snake case, and use
convertDetectorKeysToSnakeCase
to convert detector keys.Before
After
1. metricbeat data with field name "host.name" in filter query
2. NAB data with field name "value" in filter query
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.