This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Handle index not found error #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/routes/ad.ts
Outdated
| err.statusCode === 404 && | ||
| get<string>(err, 'body.error.type', '') === 'index_not_found_exception' | ||
| ) { | ||
| if (isIndexNotFoundError(err)) { | ||
| return { ok: true, response: { totalDetectors: 0, detectors: [] } }; | ||
| } | ||
| console.log('Anomaly detector - Unable to search detectors', err); |
There was a problem hiding this comment.
nit: would prefer logging before any return, right after catch. same below.
There was a problem hiding this comment.
nit: would prefer logging before any
return, right aftercatch. same below.
In this case, do you mean adding an additional log in the if block here? Could add
There was a problem hiding this comment.
no. just moving console.log() before if(isIndexNotFoundError)should be good.
There was a problem hiding this comment.
yeah I see, will change
yizheliu-amazon
approved these changes
Aug 11, 2020
ylwu-amzn
reviewed
Aug 11, 2020
ylwu-amzn
approved these changes
Aug 11, 2020
ohltyler
added
the
enhancement
yizheliu-amazon
pushed a commit
that referenced
this pull request
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
#267 propagated a generic message to the user when there was errors retrieving detectors on the dashboard and detector list pages. One of these errors included an
index_not_found_exception, which is most likely not an error, but is because the housekeeping AD indices are not all created until a user creates and starts a detector.This fixes that by suppressing that error, similar to how the existing
searchDetector()was doing it, and consequently doesn't show any errors on the dashboard and detector list pages when those indices don't exist yet.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.