This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove static page of initialization and failure case, add auto-check of detector state when initializing #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of detector state when initializing
ohltyler
reviewed
Jun 20, 2020
| const isInitOvertime = get(initializationInfo, IS_INIT_OVERTIME_FIELD, false); | ||
| const initDetails = get(initializationInfo, INIT_DETAILS_FIELD, {}); | ||
| const initErrorMessage = get(initDetails, INIT_ERROR_MESSAGE_FIELD, ''); | ||
| const initActionItem = get(initDetails, INIT_ACTION_ITEM_FIELD, ''); | ||
|
|
||
| const isInitializingNormaly = isDetectorInitializing && !isInitOvertime; |
There was a problem hiding this comment.
good catch. changed
ylwu-amzn
approved these changes
Jun 20, 2020
ohltyler
approved these changes
Jun 20, 2020
ohltyler
added
the
enhancement
This was referenced Jun 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove static page of initialization and failure case, add auto-check of detector state when initializing
Issue #, if available:
Description of changes:
Before:
Initializing:
Failure:
After:
Initializing:
Failure:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.